feat(core): add pdf embed preview feature flag #9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9307 +/- ##
========================================
Coverage 51.91% 51.91%
========================================
Files 2152 2152
Lines 97438 97438
Branches 16282 16282
========================================
Hits 50589 50589
+ Misses 45565 45299 -266
- Partials 1284 1550 +266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
58b3e5e to
fcdb891
Compare
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
from
55d78e3 to
8ab02ef
Compare
fundon
force-pushed
the
fundon/11_14_pdf_viewer_supports_fit_to_page
branch
from
fcdb891 to
bcf3ce0
Compare
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
from
8ab02ef to
30eb2a6
Compare
fundon
changed the base branch from
fundon/11_14_pdf_viewer_supports_fit_to_page
to
graphite-base/9307
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
from
30eb2a6 to
c1f85f7
Compare
fundon
force-pushed
the
graphite-base/9307
branch
from
bcf3ce0 to
42ab507
Compare
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
3 times, most recently
from
71dd168 to
8428e53
Compare
fundon
changed the title
fundon
changed the title
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
from
8428e53 to
e95ea4c
Compare
graphite-app
bot
requested review from
CatsJuice,
pengx17,
JimmFly,
EYHN and
forehalo
pengx17
approved these changes
Dec 26, 2024
Merge activity
|
fundon
added a commit
that referenced
this pull request
Dec 26, 2024
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
from
e95ea4c to
3696139
Compare
fundon
force-pushed
the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
from
3696139 to
96fae47
Compare
graphite-app
bot
deleted the
fundon/12_25_add_pdf_embed_view_feature_flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: AF-1551